Skip to content

test: use available API ports in browser snapshots #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 4 commits into from
Oct 12, 2026
Merged

test: use available API ports in browser snapshots #3006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
504ba0e
test: use ephemeral API ports in browser snapshots
fengmk2 Oct 12, 2026
9ab832d
test: select explicit available ports for Vitest browser fixtures
fengmk2 Oct 12, 2026
035f081
test: select browser ports after Vitest resolves defaults
fengmk2 Oct 12, 2026
70f907a
Merge branch 'main' into test/browser-snapshot-ports
fengmk2 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/test_v5_preview/verify.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,17 @@ let runner;
try {
runner = await createVitest({ config: false, watch: false, reporters: [] }, defineConfig({
...(browserDefines ? { define: { __VP_STRING_DEFINE__: JSON.stringify('/messages'), __VP_BOOL_DEFINE__: 'false' } } : {}),
plugins: [{
name: 'browser-server-port',
// Set port 0 after Vitest resolves its defaults so the OS chooses the port.
enforce: 'post',
config: {
order: 'post',
handler(config) {
config.test.api.port = 0;
},
},
}],
test: {
include: [browserDefines ? 'defines.test.js' : realTimers ? 'upstream.test.js' : 'browser.test.js'],
browser: { enabled: true, provider, headless: false, instances: [{ browser: 'chromium' }] },
Expand Down
29 changes: 21 additions & 8 deletions crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/test_v5_screenshots/verify.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,28 @@ const dimensions = (file) => {
for (const phase of ['record', 'compare', 'failure']) {
const runner = await createVitest({
config: false, watch: false, reporters: [], update: phase === 'record',
}, defineConfig({ test: {
include: [phase === 'failure' ? 'failure.test.js' : 'browser.test.js'],
browser: {
enabled: true, provider: playwright(), headless: !headed, ui: false,
instances: [{ browser: 'chromium' }], viewport: { width: 800, height: 600 },
screenshotFailures: true, screenshotDirectory: 'manual-images',
expect: { toMatchScreenshot: { screenshotDirectory: 'reference-images' } },
}, defineConfig({
plugins: [{
name: 'browser-server-port',
// Set port 0 after Vitest resolves its defaults so the OS chooses the port.
enforce: 'post',
config: {
order: 'post',
handler(config) {
config.test.api.port = 0;
},
},
}],
test: {
include: [phase === 'failure' ? 'failure.test.js' : 'browser.test.js'],
browser: {
enabled: true, provider: playwright(), headless: !headed, ui: false,
instances: [{ browser: 'chromium' }], viewport: { width: 800, height: 600 },
screenshotFailures: true, screenshotDirectory: 'manual-images',
expect: { toMatchScreenshot: { screenshotDirectory: 'reference-images' } },
},
},
} }));
}));
try {
const result = await runner.start();
assert.equal(result.unhandledErrors.length, 0, JSON.stringify(result.unhandledErrors));
Expand Down
Loading