Skip to content

perf(ci): use a pinned prepacked Windows SDK - #2995

Draft
fengmk2 wants to merge 3 commits into
mainfrom
perf/ci-windows-sysroot
Draft

fengmk2 wants to merge 3 commits into
mainfrom
perf/ci-windows-sysroot

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Cold Windows jobs unpack MSVC installer archives during compilation. A cache miss adds several minutes to the build.

Download a pinned Windows SDK archive, verify its SHA-256 checksum, and cache its headers and x64 libraries. Adapt its paths for cargo-xwin and keep the clang-cl compiler driver.

Use Clang 22 for the SDK headers. Set -fno-delete-null-pointer-checks because Detours adds an offset to a null pointer when it injects DLLs. All existing Windows builds and tests remain enabled.

An isolated comparison is running against main at 2e9d7cb0f, with this PR at 94440c95c. It measures SDK acquisition and Windows native builds with empty and exact-hit SDK caches. Cargo and native binary caches are disabled in both variants. The comparison uses two alternating pairs for each SDK cache state.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://perf-ci-windows-sysroot-viteplus-dev.voidzero-docs.workers.dev (commit 94440c9)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f9d9c3da-viteplus-dev.voidzero-docs.workers.dev 94440c9 2026-10-14T03:51:41.307Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://62777298-viteplus-dev.voidzero-docs.workers.dev 8333c60 2026-10-12T03:23:26.359Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://ecb85da3-viteplus-dev.voidzero-docs.workers.dev 4ce3044 2026-10-12T02:11:20.667Z Visit the dashboard ↗

@fengmk2 fengmk2 added the test: e2e Auto run e2e tests label Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

CLI artifact sizes (94440c9)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.
The dist rows use the Linux build. The core total excludes .node files to match the release artifact.

Artifact Format Base PR Change
packages/cli/dist Directory total 2.21 MiB 2.21 MiB 0 B (0.00%)
packages/core/dist Directory total 4.08 MiB 4.08 MiB 0 B (0.00%)
Combined package dist Directory total 6.29 MiB 6.29 MiB 0 B (0.00%)
vp (Linux x64) Binary 11.42 MiB 11.42 MiB 0 B (0.00%)
vp (Linux x64) gzip -9 4.93 MiB 4.93 MiB 0 B (0.00%)
NAPI (Linux x64) Binary 33.69 MiB 33.69 MiB 0 B (0.00%)
NAPI (Linux x64) gzip -9 13.41 MiB 13.41 MiB 0 B (0.00%)
vp (macOS ARM64) Binary 8.50 MiB 8.50 MiB 0 B (0.00%)
vp (macOS ARM64) gzip -9 4.31 MiB 4.31 MiB 0 B (0.00%)
NAPI (macOS ARM64) Binary 40.96 MiB 40.96 MiB 0 B (0.00%)
NAPI (macOS ARM64) gzip -9 17.64 MiB 17.64 MiB 0 B (0.00%)
vp (Windows x64) Binary 9.29 MiB 9.29 MiB 0 B (0.00%)
vp (Windows x64) gzip -9 4.05 MiB 4.05 MiB -9 B (-0.00%)
NAPI (Windows x64) Binary 29.53 MiB 29.72 MiB +201.00 KiB (+0.66%)
NAPI (Windows x64) gzip -9 12.03 MiB 12.12 MiB +89.00 KiB (+0.72%)
Trampoline (Windows x64) Binary 13.50 KiB 13.50 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 7.08 KiB 7.09 KiB +4 B (+0.06%)
Installer (Windows x64) Binary 4.63 MiB 4.63 MiB 0 B (0.00%)
Installer (Windows x64) gzip -9 2.17 MiB 2.17 MiB -215 B (-0.01%)

@fengmk2
fengmk2 force-pushed the perf/ci-windows-sysroot branch from 8333c60 to 94440c9 Compare October 14, 2026 03:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: e2e Auto run e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant