Skip to content

fix: prevent Azure setupRef command injection - #184

Merged
fengmk2 merged 2 commits into
mainfrom
fix/azure-setup-ref-injection
Oct 8, 2026
Merged

fengmk2 merged 2 commits into
mainfrom
fix/azure-setup-ref-injection

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 8, 2026

Copy link
Copy Markdown
Member

azure/setup-vp.yml inserted setupRef directly into Bash and PowerShell scripts. A crafted value could execute commands on the agent.

Both prepare steps now read SETUP_VP_SETUP_REF from the environment and reject unsafe values before the bootstrap download. The allowed format supports release tags, branch paths, and commit SHAs.

@fengmk2
fengmk2 marked this pull request as ready for review October 8, 2026 03:42
@fengmk2
fengmk2 added this pull request to stack #186 October 8, 2026 04:09
@fengmk2
fengmk2 merged commit ad9155c into main Oct 8, 2026
80 checks passed
@fengmk2
fengmk2 deleted the fix/azure-setup-ref-injection branch October 8, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant