Repository navigation
Robj/async durable barrier - #688
Merged
Merged
Conversation
Make NULL blocking for optimize and durable_barrier, retain caller-owned notifications for tracked completion, and remove the separate async barrier and public blocking initializer. Keep synchronous barriers allocation-free and give internal optimize notifications waiter/completion references for safe cleanup. Validate lifetime races, shared-process completion, allocation failures, public and internal regressions, and ASan. Record 44 serialized disk-backed measurements, including an unattributed 2.4% repeated-optimize regression and a 16.6 ns inline wrapper increment.
✅ Deploy Preview for splinterdb canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support asynchronous durable barriers, using the same notification mechanism from the optimize api.
Also changes the notification infrastructure so that a NULL notification requests blocking, and adds a #define for fire-and-forget. This hopefully makes it a little easier to use blocking and fire-and-forget notification modes.