Repository navigation
chore(deps): replace nypm with package-manager-detector - #572
Merged
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
Swap the unified nypm package-manager API for antfu-collective's package-manager-detector across kit, vitest, and oxc. Detection now goes through `detect`, and install/dlx command lines are resolved via `resolveCommand`, with the vitest launcher running its `@vitest/ui` install through tinyexec.
Run the on-demand `@vitest/ui` install through `ctx.terminals.startChildProcess` instead of tinyexec, so the install streams into DevTools as a tracked terminal session (matching the oxc setup and the kit install launcher). Drops the now-unused tinyexec dep.
`@clack/prompts` 1.8.1 types the prompt cancel value as a `unique symbol`, which stopped narrowing out of `promptValue`'s return, breaking the release-script typecheck. Return `Exclude<T, symbol>` so callers see the prompt value without the cancel symbol.
antfubot
force-pushed
the
deps/replace-nypm-with-pm-detector
branch
from
September 15, 2026 01:57
f50c605 to
247ba52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the unified
nypmpackage-manager API with antfu-collective'spackage-manager-detectoracross the packages that install optional integrations on demand.detect({ cwd })(agent + version) instead ofdetectPackageManager.resolveCommand(agent, 'add' | 'execute', args):packages/kitcreateInstallLauncherresolves theadd -D <specs>command and runs it as a tracked terminal session.packages/oxcoxlint/oxfmt setup build theiradd/execute(dlx) command strings via a small sharedutils/package-managerhelper.packages/vitestruns the resolvedadd -D @vitest/uiinstall throughtinyexec(sincepackage-manager-detectorresolves commands rather than executing them), surfacing failures viaVTDT0001.nypmforpackage-manager-detector;tinyexecadded to@vitejs/devtools-vitest. Remainingnypmentries in the lockfile are transitive (nuxt/devtools et al.).DTK0050,VTDT0001) updated to reference the new dependency.Verified with
pnpm lint,pnpm test,pnpm typecheck, andpnpm build.Linked Issues
Additional context
This PR was created with the help of an agent.