Skip to content

chore: publish releases through GitHub Actions - #54

Merged
ibgreen merged 1 commit into
masterfrom
codex/github-actions-release
Aug 31, 2026
Merged

ibgreen merged 1 commit into
masterfrom
codex/github-actions-release

Conversation

@ibgreen

@ibgreen ibgreen commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Goal

Align dev-tools releases with the tag-driven workflow used by the other vis.gl repositories, so a maintainer only creates the version commit and tag locally while GitHub Actions performs the npm publication.

Changes

  • change publish-beta and publish-prod to the ocular-publish version-only-* modes
  • add a v* tag workflow that verifies the tag belongs to master or a release branch
  • install, build, lint, and test packages before publication
  • publish from the tag with ocular-publish from-git and the repository npm token
  • use Node 22 and current Node 24-based GitHub actions

Validation

  • yarn build
  • yarn lint
  • yarn test
  • git diff --check

Release follow-up

After this lands, yarn publish-beta on master will create and push v2.0.0-alpha.7; this workflow will then publish the packages to npm under the beta tag.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T18:15:00.308287Z f184a9e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33423545871

Coverage remained the same at 54.128%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 609
Covered Lines: 321
Line Coverage: 52.71%
Relevant Branches: 481
Covered Branches: 269
Branch Coverage: 55.93%
Branches in Coverage %: Yes
Coverage Strength: 4.58 hits per line

💛 - Coveralls

@ibgreen
ibgreen merged commit 4c48eb9 into master Aug 31, 2026
1 check passed
@ibgreen
ibgreen deleted the codex/github-actions-release branch August 31, 2026 18:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f184a9e4be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +17 to +18
- name: Fetch remote branches
run: git fetch origin --depth=1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fetch enough history before testing branch ancestry

If the permitted branch advances after the release tag is pushed but before check_branch runs, this depth-one fetch retrieves only the new branch tip, leaving the tagged commit behind a shallow boundary. Consequently, git branch --contains "$GITHUB_SHA" cannot establish that origin/master or the release branch contains the tag, should_build remains empty, and a valid release is silently skipped. The git fetch --depth documentation confirms that this option limits history from each remote branch tip; fetch complete ancestry (for example with fetch-depth: 0) before performing the containment check.

Useful? React with 👍 / 👎.

Comment on lines +78 to +79
- name: Publish to npm
run: npx ocular-publish from-git

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Make the publish step safe to rerun

If lerna publish fails after publishToNPM has successfully created the GitHub release—for example, after publishing only some of the three packages—rerunning this workflow invokes from-git again, but github-release.ts attempts the same release creation first and exits on GitHub's already-exists response before reaching npm. This defeats the existing partial-publication recovery logic in get-npm-dist-tag.ts; the workflow should tolerate an existing release or publish packages before creating it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants