Repository navigation
setpgid: accept a command and arguments that are not valid UTF-8 - #655
Merged
Merged
Conversation
sylvestre
reviewed
Oct 4, 2026
| } | ||
|
|
||
| #[test] | ||
| #[cfg(target_os = "linux")] |
Contributor
There was a problem hiding this comment.
why only linux? /bin/sh should be there on every unix
Contributor
Author
There was a problem hiding this comment.
/bin/sh is available on macOS, but the test cannot create the link there. APFS rejects a link name containing invalid UTF-8, and symlink fails with Illegal byte sequence.
I changed the condition to #[cfg(all(unix, not(target_os = "macos")))], as in test_last.rs, so the test now runs on the other Unix targets instead of Linux only.
Read the command and its arguments as OsString so they reach execvp() unchanged, as they do with util-linux setpgid.
SichenLiang
force-pushed
the
setpgid-non-utf8-args
branch
from
October 5, 2026 03:17
56fa700 to
0553e25
Compare
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the program name and its arguments as
OsStringso they reachexecvp()unchanged. This allows both non-UTF-8 arguments and program paths, matching util-linux 2.42.4.If
execvp()fails, the diagnostic still displays the program name withto_string_lossy(), assetsiddoes.The Unix tests cover a non-UTF-8 argument and, on Linux, a command run through a symlink whose name contains byte
ff.Fixes #654