Repository navigation
chmod: preserve metadata errors for overlong paths - #15499
Merged
sylvestre merged 1 commit intoOct 23, 2026
Merged
Conversation
sylvestre
reviewed
Oct 18, 2026
| enum ChmodError { | ||
| #[error("{}", translate!("chmod-error-cannot-stat", "file" => _0.quote()))] | ||
| CannotStat(PathBuf), | ||
| #[error("{}", translate!("perms-cannot-access", "file" => _0.quote(), "error" => strip_errno(_1)))] |
Contributor
There was a problem hiding this comment.
for --reference GNU says "failed to get attributes of 'x': ...", not "cannot access"
could you please keep a separate variant for the reference file?
sylvestre
reviewed
Oct 18, 2026
| #[error("{}", translate!("chmod-error-cannot-stat", "file" => _0.quote()))] | ||
| CannotStat(PathBuf), | ||
| #[error("{}", translate!("perms-cannot-access", "file" => _0.quote(), "error" => strip_errno(_1)))] | ||
| CannotStat(PathBuf, std::io::Error), |
Contributor
There was a problem hiding this comment.
chmod-error-cannot-stat is now unused, please remove it from the ftl files too
sylvestre
reviewed
Oct 18, 2026
| .arg("700") | ||
| .arg(&path) | ||
| .arg("valid") | ||
| .fails_with_code(1); |
Contributor
There was a problem hiding this comment.
please check the whole message ("cannot access ...: File name too long"), not only the errno
limadog9
force-pushed
the
fix/chmod-stat-error-context-12828
branch
2 times, most recently
from
October 19, 2026 11:36
1c1e0c8 to
44f3193
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Oct 19, 2026
| chmod-verbose-mode-retained = mode of {$file} retained as {$mode_octal} ({$mode_display}) | ||
| chmod-verbose-failed-change = failed to change mode of file {$file} from {$old_mode} ({$old_mode_display}) to {$new_mode} ({$new_mode_display}) | ||
| chmod-verbose-mode-changed = mode of {$file} changed from {$old_mode} ({$old_mode_display}) to {$new_mode} ({$new_mode_display}) | ||
| chmod-error-reference-stat = failed to get attributes of { $file }: { $error } |
Contributor
There was a problem hiding this comment.
could you please move it next to the other chmod-error-* keys? (same in fr-FR.ftl)
Preserve metadata errors for operands and --reference files so overlong paths report File name too long. Add regressions for recursive operation and continued processing. Closes uutils#12828.
limadog9
force-pushed
the
fix/chmod-stat-error-context-12828
branch
from
October 19, 2026 19:39
44f3193 to
9625395
Compare
Contributor
|
Thanks for your PR |
sylvestre
added a commit
to sylvestre/coreutils-1
that referenced
this pull request
Oct 25, 2026
* tests/chmod/partial-fail.sh: Ensure ENAMETOOLONG is reported for an operand and for --reference, and that later operands are still processed, with and without -R. uutils/coreutils#15499
hubot
pushed a commit
to coreutils/coreutils
that referenced
this pull request
Oct 25, 2026
* tests/chmod/partial-fail.sh: Ensure ENAMETOOLONG is reported for an operand and for --reference, and that later operands are still processed, with and without -R. uutils/coreutils#15499 Link: #396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve metadata errors for operands and --reference files so overlong paths report File name too long. Add regressions for recursive operation and continued processing.
Closes #12828.