Repository navigation
interpreter: implement RS regexp and blank-line record splitting - #133
Open
Franklin-Qi wants to merge 1 commit into
Open
Franklin-Qi wants to merge 1 commit into
Franklin-Qi wants to merge 1 commit into
Conversation
|
GNU awk testsuite comparison: |
|
GNU awk testsuite comparison: |
sylvestre
reviewed
Oct 9, 2026
sylvestre
reviewed
Oct 9, 2026
| // Single character, or POSIX: only the first character of `RS`. | ||
| self.read_record_until_char(c, reader) | ||
| } else { | ||
| // Non-empty but not valid UTF-8 start: treat as regexp bytes. |
Contributor
There was a problem hiding this comment.
in Posix mode this still takes the regexp path, is that intended?
sylvestre
reviewed
Oct 9, 2026
sylvestre
reviewed
Oct 9, 2026
sylvestre
reviewed
Oct 9, 2026
sylvestre
reviewed
Oct 9, 2026
sylvestre
reviewed
Oct 9, 2026
| } | ||
|
|
||
| #[test] | ||
| fn rs_empty_match_does_not_split_characters() { |
Contributor
There was a problem hiding this comment.
please also add tests for RT with RS = "": leading newlines, several blank lines between records, and trailing newlines at EOF
Collaborator
Author
There was a problem hiding this comment.
Okay, I have add tests.
Wire RT as a builtin and finish the missing RS modes (multi-char regexp and RS=""). Cache the RS automaton, keep reading when a match touches the buffer end, and consume rs_leftover when RS switches mid-file. Closes: uutils#124
Franklin-Qi
force-pushed
the
feature-issue#124-record-splitting
branch
from
October 10, 2026 10:26
6440887 to
509fb42
Compare
|
GNU awk testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire RT as a builtin and finish the missing RS modes (multi-char regexp and RS="") so record boundaries and RT match gawk.
Closes: #124