Skip to content

feat[frontend](datasources): add Export PDF report of fleet health + … - #3027

Merged
AlexSanchez-bit merged 2 commits into
release/v12.0.0from
backlog/v12_datasources_report
Nov 2, 2026
Merged

AlexSanchez-bit merged 2 commits into
release/v12.0.0from
backlog/v12_datasources_report

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@AlexSanchez-bit AlexSanchez-bit linked an issue Nov 2, 2026 that may be closed by this pull request
1 of 2 tasks
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

✅ architecture (silas-1.7-pro) — clean

Summary: Frontend-only PDF export feature with i18n; no backend, agent, contract, migration, or CI changes detected.

No findings.

🛑 bugs (silas-1.7-pro) — high/critical — please review

Summary: Adds PDF export with hidden iframe; missing cleanup on error, unreachable close, early promise resolution, and minor i18n typo.

  • high frontend/src/features/datasources/lib/export-report.ts:122 — exportReportPdf appends the hidden backdrop before awaiting buildReportHtml and has no cleanup if buildReportHtml throws; a failed svc.list leaves the backdrop in document.body. Reproduce by mocking list to reject and clicking Export.
  • high frontend/src/features/datasources/lib/export-report.ts:108 — backdrop is set to width:0/height:0/offscreen, so closeBtn is unreachable; if win.print() throws or afterprint never fires, the overlay cannot be removed. Reproduce by forcing print to fail or in a browser where afterprint is unsupported.
  • medium frontend/src/features/datasources/pages/DataSourcesPage.tsx:343 — runExport awaits onExport, but exportReportPdf resolves after setting frame.srcdoc, before iframe onload/win.print(); exporting is reset too early, allowing repeated clicks to create multiple overlays/print dialogs. Reproduce by clicking Export again before the print dialog appears.
  • low frontend/src/features/datasources/lib/export-report.ts:33 — online = total - offline mixes count endpoint total with offline count from fetched list; if total is lower than offline (stale count or pagination mismatch), the report renders a negative online value. Reproduce by making count return a total smaller than the number of offline sources in all.
  • low frontend/src/shared/i18n/locales/it.json:3963 — User-facing typo: 'reporto' should be 'report' in 'Impossibile esportare il reporto'.
  • low frontend/src/shared/i18n/locales/it.json:4039 — User-facing typo: 'Reporto' should be 'Report' in 'UTMStack — Reporto sui dati sorgente'.

✅ security (silas-1.7-pro) — clean

Summary: No new vulnerabilities or customer-facing internal identifier leaks introduced by the frontend PDF export changes.

No findings.

🔴 go-deps — pending updates

🔍 Discovered 31 Go projects

📦 Dependencies with updates available:

  📁 ./agent:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.38
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./tools/rulecheck:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38

  📁 ./collectors/forwarder:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./collectors/as400:
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./collectors/utmstack:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./installer:
     - github.com/cloudfoundry/gosigar: v1.3.128 → v1.3.130

  📁 ./backend:
     - github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: v1.8.2 → v1.8.3
     - github.com/aws/aws-sdk-go-v2/config: v1.33.12 → v1.33.13
     - github.com/aws/aws-sdk-go-v2/credentials: v1.20.12 → v1.20.13
     - github.com/gin-contrib/cors: v1.7.9 → v1.7.10
     - github.com/jackc/pgx/v5: v5.11.0 → v5.12.0

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2/config: v1.33.12 → v1.33.13
     - github.com/aws/aws-sdk-go-v2/credentials: v1.20.12 → v1.20.13
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.90.3 → v1.91.0

  📁 ./plugins/azure:
     - github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: v1.8.2 → v1.8.3

❌ Please update dependencies before merging.

@AlexSanchez-bit
AlexSanchez-bit merged commit c6ceb76 into release/v12.0.0 Nov 2, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_datasources_report branch November 2, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pdf report on datasources page

1 participant