Skip to content

fix[frontend](alerts): fixed related evets auto navigation and window… - #3001

Merged
AlexSanchez-bit merged 2 commits into
release/v12.0.0from
backlog/v12_front_fix
Oct 28, 2026
Merged

AlexSanchez-bit merged 2 commits into
release/v12.0.0from
backlog/v12_front_fix

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

⚠️ architecture (silas-1.7-pro) — minor findings

Summary: Frontend data-fetching lifecycle and log-explorer query params changed; no critical-path or agent contract impact.

  • medium frontend/src/features/alerts/components/alert-drawer.tsx:77 — AlertDrawer now always enables useAlertThreadEvents and removes the effect that calls viewRelatedLogs(a), changing data-fetching lifecycle and potentially stopping related logs from loading. Keep lazy enable tied to tab or move the trigger into the appropriate hook.
  • low frontend/src/features/alerts/hooks/use-alert-thread-events.ts:51 — Effect dependency array drops echoes while the effect likely depends on it; this can cause stale event data. Include echoes or derive events without an effect.
  • low frontend/src/features/user-auditor/helpers/user-auditor-display.ts:79 — Changes log-explorer query params from eventCode/eventDataTargetSid to log.eventCode/log.eventDataTargetSid; confirm the log-explorer contract and avoid breaking existing links.

🛑 bugs (silas-1.7-pro) — high/critical — please review

Summary: High-risk React hook dependency and removed related-logs fetch; possible broken log-explorer query params.

  • high frontend/src/features/alerts/components/alert-drawer.tsx:77 — The diff removes useEffect(() => { viewRelatedLogs(a) }, [a]) without replacing it, so related logs are no longer fetched when the alert drawer opens; reproduce by opening an alert and checking that the related logs view remains empty.
  • high frontend/src/features/alerts/hooks/use-alert-thread-events.ts:51 — The effect dependency array drops echoes while the effect still depends on it; changes to echoes will not trigger a refetch or refresh, causing stale thread events. Reproduce by updating echoes after the initial load and observing that events do not update.
  • medium frontend/src/features/user-auditor/helpers/user-auditor-display.ts:79 — Query parameter was renamed from eventCode to log.eventCode; if log-explorer expects the original key, generated links will no longer apply the intended event-code filter.
  • medium frontend/src/features/user-auditor/helpers/user-auditor-display.ts:80 — Query parameter was renamed from eventDataTargetSid to log.eventDataTargetSid; if log-explorer expects the original key, generated links will no longer filter by the user SID.

✅ security (silas-1.7-pro) — clean

Summary: No vulnerabilities or customer-facing information disclosure introduced by the diff.

No findings.

🔴 go-deps — pending updates

🔍 Discovered 31 Go projects

📦 Dependencies with updates available:

  📁 ./agent:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.38
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./tools/rulecheck:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38

  📁 ./agent-manager:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./collectors/forwarder:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./collectors/as400:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./collectors/utmstack:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./backend:
     - github.com/aws/aws-sdk-go-v2/config: v1.33.11 → v1.33.12
     - github.com/aws/aws-sdk-go-v2/credentials: v1.20.11 → v1.20.12
     - github.com/aws/aws-sdk-go-v2/service/sts: v1.51.5 → v1.51.6
     - google.golang.org/grpc: v1.84.0 → v1.85.0

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2: v1.47.4 → v1.47.5
     - github.com/aws/aws-sdk-go-v2/config: v1.33.11 → v1.33.12
     - github.com/aws/aws-sdk-go-v2/credentials: v1.20.11 → v1.20.12
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.90.2 → v1.90.3

  📁 ./log-input:
     - google.golang.org/grpc: v1.84.0 → v1.85.0

❌ Please update dependencies before merging.

@AlexSanchez-bit
AlexSanchez-bit merged commit 087c72e into release/v12.0.0 Oct 28, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_front_fix branch October 28, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant