Skip to content

ci: pin release workflow actions to commit SHAs - #3

Open
rcooney-sh wants to merge 1 commit into
mainfrom
vulnagent/hygiene-2026-09-pin-release-actions
Open

rcooney-sh wants to merge 1 commit into
mainfrom
vulnagent/hygiene-2026-09-pin-release-actions

Conversation

@rcooney-sh

@rcooney-sh rcooney-sh commented Sep 24, 2026 •

Copy link
Copy Markdown

The release workflow builds and publishes hypervisor binaries. Pin all actions it invokes to full commit SHAs so tag movement cannot change the dependencies without review.

uses: houseabsolute/actions-rust-cross@21b0f18dc621b25bfae556ff2791fca4173121e8 # v1.0.8

Covered problem IDs: prb_2925febab561dd96. Linear: SEC-696. Aikido findings: 469989209, 469989215.

Promotion risk: Low. CI-only change to the release workflow. No hypervisor code changes.

  • Runtime change: none for the binaries. The tag release resolves each action to a fixed commit instead of a moving tag.
  • What could break: only the next tag release. Each pin was resolved from the tag it replaces (actions-rust-cross@v1 compared with v1.0.8), so behavior should match. If a pin were wrong, the release job would fail to resolve the action or produce no draft release; nothing is published silently.
  • Evidence: pinned SHAs resolved and compared by hand. The release workflow runs only on tag create and merge_group, so PR CI did not exercise it. Out of scope: the identical release.yaml on the patchset branch, and the floating refs actions-rust-cross uses internally. Dependabot keeps these pins current. quality and formatting already fail on main. dco fails because the bot sign-off does not match the commit author, which needs an admin merge or a re-signed commit.
  • Blast radius / rollback / watch: only the next cloud-hypervisor release build; consumers pick it up only when they move to that release. Roll back by reverting. Watch the first tag release produce its draft release and artifacts.

View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled. (Staging)


View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.

release.yaml builds and publishes the cloud-hypervisor and ch-remote
binaries and consumed them from floating tags. Pin every action it uses
to the full commit SHA of its current release so a moved or compromised
tag cannot alter shipped artifacts. The existing Dependabot
github-actions config keeps these pins updated.

Signed-off-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>

Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
@rcooney-sh
rcooney-sh marked this pull request as ready for review September 24, 2026 20:56
@linear-code

linear-code Bot commented Oct 20, 2026

Copy link
Copy Markdown

SEC-696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant