Repository navigation
fix(orchestrator): repair Created record when dependency-analysis re-announces - #875
Open
behinddwalls wants to merge 1 commit into
Open
behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
…announces ## Summary ### Why? `corebatch.Transition` CASes the batch before filing its per-state membership record, and the transition protocol relies on the already-in-target-state retry calling `EnsureRecord` to repair a crash between the two. The dependency-analysis re-announce branch (batch already `Created`) skipped it, so a crash there left a `Created` batch invisible to `ListByStates` — the next batch's analysis would not serialize behind it until speculate happened to admit it. ### What? - Call `corebatch.EnsureRecord` in the `Created` re-announce branch before re-publishing to speculate. - Update the pipeline diagram in the `Stages` doc to include the `dependency-analysis` stage. ## Test Plan ✅ `bazel test //submitqueue/orchestrator/controller/dependencyanalysis/...` (re-announce test now requires the `Created` record put) ✅ `make lint`
behinddwalls
marked this pull request as ready for review
October 16, 2026 12:56
behinddwalls
added this pull request to stack #877
October 16, 2026 12:56
mnoah1
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
corebatch.TransitionCASes the batch before filing its per-state membership record, and the transition protocol relies on the already-in-target-state retry callingEnsureRecordto repair a crash between the two. The dependency-analysis re-announce branch (batch alreadyCreated) skipped it, so a crash there left aCreatedbatch invisible toListByStates— the next batch's analysis would not serialize behind it until speculate happened to admit it.What?
corebatch.EnsureRecordin theCreatedre-announce branch before re-publishing to speculate.Stagesdoc to include thedependency-analysisstage.Test Plan
✅
bazel test //submitqueue/orchestrator/controller/dependencyanalysis/...(re-announce test now requires theCreatedrecord put)✅
make lintStack
🤖 Generated with Claude Code