Repository navigation
feat(stovepipe): include current summaries in request history - #848
Merged
Merged
Conversation
Summary: ## Why? History callers need the current request status alongside retained lifecycle events. ## What? Add `request_summary` to both request-history response shapes, preserving existing event fields and field numbers. Both selectors share a reader for retained logs and the stored current summary; wire mapping reuses the existing summary mapper. Successful lookups require a summary. A missing summary fails with a retryable infrastructure error because initial log persistence precedes summary creation. Summary identity or URI mismatches fail as consistency errors. Summaries are not reconstructed from retained event subsets. Use a generated controller mock in handler tests and update the history contract documentation. ## Test Plan - Bazel controller, mapper, and handler unit tests passed. - Docker integration suite passed, including failed lookups before summary creation and successful responses afterward, without an operational Request row. - `make lint check-tidy check-gazelle check-mocks` passed. ## Issue None.
mnoah1
marked this pull request as ready for review
October 12, 2026 20:27
prathshenoy
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
History API already includes individual events. Callers may want to display a current snapshot (provided by the summary) along side the historical events that led to that point.
What?
Add
request_summaryto both request-history response shapes, preserving existing event fields and field numbers. Both selectors share a reader for retained logs and the stored current summary; wire mapping reuses the existing summary mapper.Successful lookups require a summary. A missing summary fails with a retryable infrastructure error because initial log persistence precedes summary creation. Summary identity or URI mismatches fail as consistency errors. Summaries are not reconstructed from retained event subsets.
Use a generated controller mock in handler tests and update the history contract documentation.
Test Plan
make lint check-tidy check-gazelle check-mockspassed.