fix(webapp): display imperative schedules without active worker deployments (#3209) - #4970
kaiizer777 wants to merge 1 commit into
Conversation
|
Hi @kaiizer777, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Presenter test is not colocated
Repository guidance requires new tests beside their source file. Move this suite alongside ScheduleListPresenter.server.ts before merging.
Was this helpful? React with 👍 or 👎 to provide feedback.
| vi.setConfig({ testTimeout: 60_000 }); | ||
|
|
||
| async function seedProjectWithEnv(prisma: PrismaClient, slugBase: string) { | ||
| const slug = `${slugBase}_${Math.random().toString(36).slice(2, 10)}`; |
There was a problem hiding this comment.
🔍 Fixtures use unseeded randomness
Math.random() makes fixture values irreproducible. Repository guidance requires seeded randomness in tests.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Closes #3209
Overview
Fixes an issue where imperative schedules created out-of-band (via SDK or API) prior to any active worker deployment were invisible in the UI schedule listing, despite counting towards plan limits.
Changes
ScheduleListPresenter.server.ts:!latestWorker && filterType === "DECLARATIVE".!latestWorker, setseffectiveFilterType = "IMPERATIVE"to ensure imperative schedules associated with the environment remain queryable and visible before initial worker deployment.page = 1parameter to preventskip: NaNvalidation errors.schedulePhase: number | nullonScheduleListItemusing deterministiccalculateSchedulePhasefallback.apps/webapp/test/ScheduleListPresenter.test.ts..server-changes/imperative-schedules-ui-visibility.mduser-facing release note.✅ Checklist
Testing
apps/webapp/test/ScheduleListPresenter.test.ts.pnpm run typecheck --filter webapp(0 errors).pnpm run lint(0 errors).Changelog
Display imperative schedules created before initial deployment or worker task versioning in the schedules listing.