Skip to content

fix: explicitly set machineConfig to null when task machine is removed #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepshekhardas wants to merge 1 commit into from
Closed

fix: explicitly set machineConfig to null when task machine is removed #3111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/webapp/app/v3/services/createBackgroundWorker.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ async function createWorkerTask(
exportName: task.exportName,
retryConfig: task.retry,
queueConfig: task.queue,
machineConfig: task.machine,
machineConfig: task.machine ?? null,

@devin-ai-integration devin-ai-integration Bot Feb 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Fix may be a no-op for the create path — the underlying issue might be elsewhere

In Prisma's create operation, passing undefined for an optional Json? field like machineConfig (see internal-packages/database/prisma/schema.prisma:561) is equivalent to omitting it, which uses the database default of NULL. Passing explicit null also sets the column to NULL. So for this create call at apps/webapp/app/v3/services/createBackgroundWorker.server.ts:267-286, the behavioral difference is zero.

The PR references issue #2796 about inconsistent states when a task machine is removed, but since each new background worker creates fresh BackgroundWorkerTask rows (not updating existing ones), the old machineConfig from a previous worker version wouldn't carry over regardless. The inconsistency described in the issue may stem from consumers reading machineConfig from the wrong worker version or from a different code path not addressed here. Worth verifying the actual reproduction scenario described in the issue.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

triggerSource: task.triggerSource === "schedule" ? "SCHEDULED" : "STANDARD",
fileId: tasksToBackgroundFiles?.get(task.id) ?? null,
maxDurationInSeconds: task.maxDuration ? clampMaxDuration(task.maxDuration) : null,
Expand Down