Skip to content

fix: reject duplicate usernames in the user configuration #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bsaurusrex wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reject duplicate usernames in the user configuration #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/utils/user_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (

func ParseUsers(usersStr []string, userAttributes map[string]model.UserAttributes) (*[]model.LocalUser, error) {
var users []model.LocalUser
seen := make(map[string]struct{})

if len(usersStr) == 0 {
return nil, nil
Expand All @@ -24,6 +25,10 @@ func ParseUsers(usersStr []string, userAttributes map[string]model.UserAttribute
if err != nil {
return nil, err
}
if _, dup := seen[parsed.Username]; dup {
return nil, fmt.Errorf("duplicate user %q, each username must be configured only once", parsed.Username)
}
seen[parsed.Username] = struct{}{}
if attrs, ok := userAttributes[parsed.Username]; ok {
parsed.Attributes = attrs
}
Expand Down
14 changes: 14 additions & 0 deletions internal/utils/user_utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,20 @@ import (
"github.com/tinyauthapp/tinyauth/internal/utils"
)

func TestGetUsersRejectsDuplicates(t *testing.T) {
hash := "$2a$10$Mz5xhkfSJUtPWkzCd/TdaePh9CaXc5QcGII5wIMPLSR46eTwma30G"
noAttrs := map[string]model.UserAttributes{}

// The same username twice is rejected instead of silently keeping the first
_, err := utils.GetUsers([]string{"alice:" + hash, "alice:" + hash}, "", noAttrs)
assert.ErrorContains(t, err, `duplicate user "alice"`)

// Distinct usernames still load
users, err := utils.GetUsers([]string{"alice:" + hash, "bob:" + hash}, "", noAttrs)
assert.NoError(t, err)
assert.Len(t, *users, 2)
}

func TestGetUsers(t *testing.T) {
tmpDir := t.TempDir()

Expand Down