Repository navigation
Make updater configuration immutable - #3028
Open
Harshil-1603 wants to merge 1 commit into
Open
Harshil-1603 wants to merge 1 commit into
Harshil-1603 wants to merge 1 commit into
Conversation
Signed-off-by: Harshil <181649964+Harshil-1603@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
Make
UpdaterConfiga frozen dataclass and exposeUpdater.configas a read-only property. This prevents changing settings after initialization or refresh, when some settings have already been used to initialize trusted metadata or the default fetcher.This intentionally changes the API: callers that assign settings on an existing configuration must pass them to
UpdaterConfig(...)instead, or usedataclasses.replace(...)to derive settings for a newUpdater. The API docstrings explain that migration. Existing limit and download tests now pass their settings at construction and retain their behavioral assertions.A regression test covers both mutation through the caller's original config reference and mutation/replacement through the updater, before and after refresh. It fails on the previous implementation.
Fixes #2471
Validation:
AI assistance: Codex GPT-6 was used to prepare the change.