Repository navigation
Run lint once for the whole repository - #1495
Draft
cristianrgreco wants to merge 1 commit into
Draft
cristianrgreco wants to merge 1 commit into
cristianrgreco wants to merge 1 commit into
Conversation
Biome checks every file in well under a second, so the per-module lint matrix mostly paid for runner start-up and installs. Replace it and the separate Knip job with one Lint job that runs Biome and then knip.
cristianrgreco
added
maintenance
This was referenced Oct 10, 2026
cristianrgreco
added this pull request to stack #1498
October 10, 2026 20:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1492. Review and merge that one first.
Summary
Replaces the per-module lint matrix and the separate
Knipjob with oneLintjob for the whole repository. It runsnpm run lint:ciand thennpm run knip.lint:ciis nowbiome ci --error-on-warnings .instead of taking a per-module path.npm-setup(the mode added in Detect unused code and dependencies with knip #1492), because knip needs that.if, so it also runs when onlyknip.jsoncorbiome.jsonchanges. Compile, smoke tests and tests still wait on it, and are still gated by which packages changed.Why
Biome checks all 457 files in about 0.1s. On the last all-green run of
Checks, linting took 44 jobs and 1171s of runner time (27s per job on average), nearly all of it runner start-up and per-module installs.Verification
npm run lint:ci: passes on the whole repository. It exits 1 when a badly formatted file is added under a module, so.covers the packages.npm run knip: passes.npm run format,npm run lint: no fixes applied (457 files).checks.ymlparses, and the job graph isdetect-modules,lint,compile,smoke-test,smoke-test-bun,test,end.Checksworkflow only runs for PRs that targetmain, so it won't run on this PR until Detect unused code and dependencies with knip #1492 merges and this one is retargeted.Why this isn't breaking
CI-only. No package source, dependency or published file changes.
The check name changes from
Lint (<module>)toLint.mainhas no branch protection or required status checks, so nothing needs updating.