Repository navigation
Ignore jackson-databind minor/patch updates in core Dependabot config - #12120
Merged
Merged
Conversation
core forces jackson-databind and jackson-datatype-jsr310 to the same version on purpose. Only jsr310 was ignored, so Dependabot bumped databind alone, breaking the version alignment and the shaded jar's META-INF assertions in JarFileShadingTest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
core/build.gradleforcesjackson-databindandjackson-datatype-jsr310to the same version (currently 2.18.4). Jackson is not shaded. It comes in through docker-java'sapidependencies, so the forced version is what users get on their classpath. Keeping it at a conservative floor avoids conflicts like #3433 (see #3579, #3602).dependabot.ymlalready ignores minor/patch updates forjackson-datatype-jsr310(#7143) so it stays aligned with databind.jackson-databinditself was never ignored, so #12119 bumped it alone to 2.22.3. That:jackson-core2.22.3, which has different license files (Schubfach-LICENSE,FastDoubleParser-ThirdParty-LICENSE, noFastDoubleParser-NOTICE/thirdparty-LICENSE). Those files failJarFileShadingTest.testMetaInfincore (17)/core (21).Change
Add the same minor/patch ignore rule for
com.fasterxml.jackson.core:jackson-databindin the/coreentry. Jackson bumps stay a deliberate manual change, as in #10258.After merge, #12119 should be recreated without the Jackson bump (
@dependabot recreateif needed).🤖 Generated with Claude Code
Summary by CodeRabbit