[Enhancement]: Don't call getLogs() twice in Container#tryStart

Module

Core

Proposal

Code:

testcontainers-java/core/src/main/java/org/testcontainers/containers/GenericContainer.java

Lines 540 to 544 in deb78e1

    
           // Log output if startup failed, either due to a container failure or exception (including timeout) 
        
           final String containerLogs = getLogs(); 
        
           if (containerLogs.length() > 0) { 
        
               logger().error("Log output from the failed container:\n{}", getLogs());

Should probably call getLogs() only once as it is not expected to change in between calls

Please, do not create an issue and PR at the same time.

Thank you for having a look at this and getting the PR merged :)

Please, do not create an issue and PR at the same time.

Could you please elaborate why or where this is documented?

I also created the PR after the issue because the fix was a simple one-liner.

PS: I'm usually always creating issues for PR if they don't exist because repository maintainers sometimes ignore pull requests due to an overwhelming amount of automated PR, e.g dependabot dependency updates

Navigation Menu

Repository navigation

[Enhancement]: Don't call getLogs() twice in `Container#tryStart` #11926

Module

Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Log output if startup failed, either due to a container failure or exception (including timeout)
	final String containerLogs = getLogs();

	if (containerLogs.length() > 0) {
	logger().error("Log output from the failed container:\n{}", getLogs());

[Enhancement]: Don't call getLogs() twice in Container#tryStart #11926

Description

Module

Proposal

Activity

eddumelendez commented on Jul 17, 2026

AB-xdev commented on Jul 17, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[Enhancement]: Don't call getLogs() twice in `Container#tryStart` #11926