Repository navigation
test: settle real frame edits before reload conflict checks - #19
Merged
Merged
Conversation
Open
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reload test could change the external file before all keyboard edits had reached the parent and their acknowledgements had settled, producing a valid conflict instead of the intended uncertain state. Wait for the complete observed source and acknowledgement before that assertion, and cover the coalesced-conflict case separately through the real message port.
Validation: strict TypeScript, ten repeats of the actual visual scenario, all 12 reload tests, and independent review. Production code and timeout behavior are unchanged. These are component checks, not native-app qualification.