Repository navigation
fix(ci): report late native onboarding as blocked - #18
Merged
Merged
Conversation
Open
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual Windows app retry now launches successfully, but its first-run Terms screen can appear after the initial onboarding check and intercept the optional agent-setup dismissal. The retained run consequently reported a generic click timeout.
Classify the observed welcome/mode/Terms screen as
BLOCKED_ONBOARDINGwhile keeping the original exception, screenshot, nonzero exit and untouched source files. This changes no app action, accepts no Terms and introduces no native-success path.Validation: three pure classification regressions use the exact visible text retained by native run 38750710544; all 42 source tests and driver syntax pass. Independent review verified the fixture and eleven actual native evidence hashes. The app's nineteen installed extension files and input document remained unchanged. Native editing/save/export qualification still requires completed human onboarding.
The initial Windows CI run also exposed an existing owner-invalidation test whose artificial two-second deadline expired before its real filesystem callback. Those three ownership cases now use the existing production 30-second budget. A deliberate 2.2-second real-write delay retains the reproduced regression; exact error/path/content/one-write assertions and the explicit timeout tests are unchanged. Independent Chromium verification passed all 17 export tests, and strict TypeScript passed. Production code and timeouts are unchanged.