Repository navigation
feat: wire bounded selection alternatives to host AI lifecycle - #15
Merged
Merged
Conversation
…idge-20261015 # Conflicts: # src/native-session.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect the extension's real AI service lifecycle to explicit selection-alternative controls. Requests are opt-in, bounded to the selected text and its paragraph (2,000 code points), and require a qualified host/provider. Returned suggestions remain a preview until explicit acceptance; acceptance uses the existing Rust alternative transaction and
synonyms::graph/history behavior.The released SDK exposes no supported host-version identity. The qualification list is therefore empty and the native controls stay disabled. This change sends no native provider requests and makes no external-AI qualification claim. It prepares the supported service connection and keeps local KG suggestions available.
The private frame boundary rejects changed source, role, selection and owner identities. Cancellation discards a late result while retaining the single-operation reservation; acceptance waits for the actual parent acknowledgement. The manifest adds only the approved AI permission, with package tests enforcing it.
Independent validation: strict TypeScript/SDK build, 32 source tests, 16 package tests, 33 focused browser tests plus two independent real regressions pass. Tests use actual Rust, IndexedDB and saved files; provider-seam values are labeled fixtures, not live model outputs. Additional checks prove undo/redo/save/reopen and refusal after actual recovery-store closure. After merging the qualified admission base, all 15 reviewed file hashes remain unchanged and 38 integrated browser checks pass.
Native three-OS/all-41 acceptance and a genuinely configured host/provider remain separate gates. This PR does not publish a package.