Repository navigation
feat(endode-extstore-refs): external storage references are now encoded and decoded. - #1946
Open
cconstable wants to merge 7 commits into
Open
cconstable wants to merge 7 commits into
cconstable wants to merge 7 commits into
Conversation
cconstable
marked this pull request as draft
October 8, 2026 18:15
cconstable
marked this pull request as ready for review
October 13, 2026 18:04
Contributor
|
I don't see any issues, but I'll let @jmaeagle99 review |
jmaeagle99
reviewed
Oct 14, 2026
jmaeagle99
left a comment
jmaeagle99
left a comment
Contributor
There was a problem hiding this comment.
Some comments. And we should consider a change log entry that may be a breaking change to clearly describe the behavior here. The problem is if an open workflow is processed on a worker with this change and then further processed on a worker with a prior SDK version, that will likely fail, due to references being encoded.
jmaeagle99
reviewed
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
External storage reference payloads are now encoded with the configured payload codec. Every reference carries a
__temporal_external_storage_referencemetadata marker so the SDK can decode.References written by earlier versions, which are unencoded and unmarked, are still read as before.
Why
Reference payloads contain driver claim data, such as bucket names and object keys. That data was written to workflow history in plain text, even when a codec was configured to encrypt everything else.
Checklist