Repository navigation
Restore pickling of Pydantic data converters - #1877
Merged
Merged
Conversation
tconley1428
marked this pull request as ready for review
September 16, 2026 18:43
THardy98
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1871.
Pydantic data converters fail to pickle because their type adapter cache wraps
TypeAdapterin an instance-locallru_cache. Exclude that wrapper and its contents from pickled state, then recreate an empty cache with the same size limit when unpickling. Other converter state, including JSON options, is preserved.Adds three regression cases covering the shipped data converter and empty/populated caches, verifying that a nondefault cache limit and JSON options survive unpickling. Includes a docstring note and changelog entry.
Validation:
poe formatandpoe lintpass.poe test -s -n 0 -p no:rerunfailures tests/contrib/pydantic/test_pydantic.py -k pickle(the rerun plugin requires a local socket unavailable in the sandbox).