Repository navigation
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
@MethodRetrymerging.Why?
RetryOptions.Builder.build()permits partial policies, butRetryOptions.merge(RetryOptions)unconditionally passed their unset values to setters that reject them. For example:This throws
NullPointerExceptionfor the unset initial interval. When an initial interval is supplied but neither policy sets a coefficient, merging instead throwsIllegalArgumentExceptionfor coefficient0.0.Preserving the unset values allows callers to compose retry policies before applying defaults or annotation values, without changing precedence for explicitly configured fields.
Validation
RetryOptionsTest, reproducing both exceptions.RetryOptionsTesttests pass, including the 6 new tests../gradlew --offline :temporal-sdk:spotlessApplyandgit diff --checkpass.io.temporal.common.*,ActivityOptionsTest, andRetryOptionsUtilsTest).Two existing
ActivityClientCallsInterceptorChainTesttests were skipped.Breaking changes?
None. No API signatures change; existing explicit-value precedence and null-override behavior are preserved.
Server PR
Not required.