Repository navigation
Conversation
WorkflowClient, ScheduleClient and NexusClient wrap their service stubs in NamespaceInjectWorkflowServiceStubs so every call carries the temporal-namespace header. ActivityClient did not, so Standalone Activity calls such as StartActivityExecution went out without it, and Temporal Cloud rejects them for API-key authentication with PERMISSION_DENIED: Request unauthorized. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sebastian Bruckner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
Just signed the CLA |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
ActivityClientImplnow wraps itsWorkflowServiceStubsinNamespaceInjectWorkflowServiceStubs, likeWorkflowClientInternalImpl,ScheduleClientImplandNexusClientImplalready do.Why?
Without the
temporal-namespaceheader, Standalone Activity calls (StartActivityExecutionand the rest of theActivityClientAPI) are rejected by Temporal Cloud for API-key authentication withPERMISSION_DENIED: Request unauthorized. Workflow starts through the same stubs and key work. We hit this in production use against Temporal Cloud and currently work around it by wrapping the stubs ourselves.How was this tested
Added
AuthorizationTokenTest.activityClientRequestsShouldHaveANamespace, which records the outgoing headers ofStartActivityExecution. It fails without the change (expected:<default> but was:<null>) and passes with it.