Repository navigation
Add transfer type converters - #3073
VegetarianOrc wants to merge 17 commits into
Conversation
| // Set merged plugins after configuration, then build | ||
| builder.setPlugins(mergedPlugins); | ||
| options = builder.build(); | ||
| options = |
There was a problem hiding this comment.
Why build the options then immediately call ScheduleClientOptions.newBuilder(options)?
There was a problem hiding this comment.
I took a pass at cleaning this up a little by passing the data converter into the invoker rather than pulling it from the options. Not 100% sure that's a reasonable approach so happy to consider a better alternative here if there is one.
|
We took a very different approach to wrapping the users |
Pass transfer-aware converters to Activity and Schedule invokers without rebuilding their configured options. Preserve serialization context for task-token heartbeats and propagate the configured converter to test Nexus clients.
Thanks for calling this out. I've taken a pass to consolidate the client side converter creation into I've left the worker side separate for now since the transfer type conversion happens in a workflow thread but the external storage must remain separate on that side. There may still be cleanup possible that I can explore if you think it could use some attention. |
What changed?
@TransferTypeConvertibleandTransferTypeConverterAPIs for converting top-level model values to a transfer representation before data conversion.Why?
Breaking changes?
Server PR