Repository navigation
Add ExportedExecutions type for export - #874
Merged
Merged
Conversation
|
|
alice-yin
approved these changes
Oct 5, 2026
bergundy
reviewed
Oct 5, 2026
Comment on lines
+32
to
+33
| repeated WorkflowExecution workflow_items = 1; | ||
| repeated ActivityExecution activity_items = 2; |
Member
There was a problem hiding this comment.
nit: items is redundant
Suggested change
| repeated WorkflowExecution workflow_items = 1; | |
| repeated ActivityExecution activity_items = 2; | |
| repeated WorkflowExecution workflows = 1; | |
| repeated ActivityExecution activities = 2; |
Contributor
Author
There was a problem hiding this comment.
updated, thank you!
maciejdudko
approved these changes
Oct 5, 2026
awln-temporal
approved these changes
Oct 5, 2026
bergundy
approved these changes
Oct 5, 2026
VegetarianOrc
pushed a commit
that referenced
this pull request
Oct 12, 2026
<!-- Describe what has changed in this PR --> **What changed?** Add an exported executions type for export which is wire compatible with previous WorkflowExecutions but also includes newer executions we want to export <!-- Tell your future self why have you made these changes --> **Why?** <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add an exported executions type for export which is wire compatible with previous WorkflowExecutions but also includes newer executions we want to export
Why?
Breaking changes
Server PR