Repository navigation
fix(init): group the wizard's install output, and say when the install is left uncommitted - #570
Merged
Merged
Conversation
… left uncommitted, and stop advertising DO_NOT_TRACK A migration's summary and the launcher's Created lines continue under the step that opened them, and the telemetry notice sits under its own heading, one sentence per line. Cancelling the commit question closed on "Taskless is ready to go.", which read as though the commit had happened. The wizard now re-checks git after the question and, when the install is still uncommitted, says so. DO_NOT_TRACK is still honored, but it is a cross-tool setting, so the notice, README, and recipes name only Taskless's own opt-outs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes to what
taskless init(the wizard) prints.Grouped output. A migration's summary and the launcher's
Createdlines now continue under the step that opened them, instead of each one opening a new●step. The telemetry notice sits under aTelemetry Informationheading, one sentence per line:Ctrl+C at the commit question. A cancel there is still read as "don't commit", since the install is already on disk, as the spec requires. It used to close on "Taskless is ready to go.", which read as though the commit had happened. The wizard now checks git again after the question. If the install is still uncommitted (cancelled, declined, or refused by a hook), it closes with "Taskless is installed, but its files are not committed yet."
DO_NOT_TRACKis honored but no longer advertised. It is a cross-tool setting, not a Taskless one. The notice, the README, and theinit(topic v14) andfeedback-invite(topic v5) recipes now name onlyTASKLESS_TELEMETRY_DISABLED=1and"telemetry": false. Thecli-initandcli-feedback-surveyspecs are updated to match; theanalyticsspec, which says it disables telemetry, is unchanged.Typecheck, lint, and the full CLI suite (2641 tests) pass locally.