Repository navigation
Conversation
Co-authored-by: James <catch-21@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncated pubkys shown for contacts without a resolved profile read like
pubky…poxyo. Every truncated pubky now goes through the single existing helper, which strips the prefix first and showsxxxx...xxxx.Description
PubkyPublicKeyFormat.display(app/src/main/java/to/bitkit/models/PubkyPublicKeyFormat.kt): also strips apk:prefix (in addition topubky) before taking the first 4 and last 4 characters; lengths are unchanged from what the Contacts screens already used.PubkyProfile.placeholder/PubkyProfile.forDisplay(app/src/main/java/to/bitkit/models/PubkyProfile.kt): the fallbacknamewaspublicKey.ellipsisMiddle(11), which producedpubky…poxyo. Both now usePubkyPublicKeyFormat.display. This is the value shown in every payment surface that falls back to a placeholder contact:SendSheet(contact payment preparing),SendConfirmScreen(contact payment profile),PaymentRequestsScreen,IncomingPaymentRequestDetailsScreen,CreatePaymentRequestScreen,SubscriptionsScreen,CreateSubscriptionScreen,ActivityDetailScreen,ContactActivityViewModel,ContactDetailViewModel,ContactsViewModel,PubkyChoiceViewModel,AppViewModelandPubkyRepofollow lists.PubkyAuthApprovalSheet.kt: dropped the localpubkyAuthDisplayPublicKeyduplicate and usedPubkyProfile.truncatedPublicKeyfor the profile card and success text.publicKeyvalues used for copy, share, payments and storage are untouched; only the derived display string changed.changelog.d/next/1456.fixed.md: changelog fragment.Out of Scope
PubkyPublicKeyFormat.redacted: log-only redaction keeps itspubky3r…k8yw5xgform.ProfileScreen.kt/ContactDetailScreen.ktpreviews: literal previewpublicKey = "pk8e3qm5...gxag"strings are preview fixtures, not display truncation.Design
N/A — no design available.
Preview
N/A — could not run the app in this environment (no GitHub Packages credentials for
com.synonym:*artifacts).QA Notes
Journeys
N/A — not drivable; see Manual Tests.
Manual Tests
xxxx...xxxxwithout apubkyprefix — requires a second Paykit identity, not in Capabilitiespubkyauth://request → the profile card and success text show the key asxxxx...xxxx— requires a pubky auth relay, not in CapabilitiesAutomated Checks
PubkyPublicKeyFormatTest.kt—displaystripspubkyandpk:prefixes, shortens unprefixed keys, and leaves short values unchangedPubkyAuthApprovalViewModelTest.kt— dropped the test for the deletedpubkyAuthDisplayPublicKeyhelper; coverage lives inPubkyPublicKeyFormatTest.ktcom.synonym:ldk-node-androidfrom GitHub Packages in the agent environment (GPR_USER/GPR_TOKENnot available), so unit tests and detekt rely on CI