Repository navigation
Conversation
Assistant prose highlighted ordinary words as symbol references once candidate files widened to all available files. Only accept tokens that look like identifiers (contain _, ., :, or camelCase) or are wrapped in backticks. Fixes #558
🏗️ Architecture checkChecks that Compared
Imports between modules: +0 / -0 ✅ No new problemsRun locally: |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #558
Problem
Since #489 widened symbol candidates to every available file and loaded buffer, assistant prose highlighted ordinary words (
to,first,line, ...) asOpencodeSymbolReference, andgd/<CR>on them offered unrelated locals.Fix
symbol_tokens.is_code_likegates both symbol target creation and highlighting informatter.lua. A token qualifies when it:_,.or:(switch_to_mode,M.apply,A::b), orfooBar), or`first`).Plain words in prose, and plain words inside fenced blocks or longer inline spans, no longer match.
Tests
is_code_likeand prose filtering in the formatter.symbol-reference-navigation.jsonfixture to backtick the barecollecttoken.make checkpasses.