Skip to content

Fix dangling stack references in ParseGuid and subscription parsing #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritchiecarroll merged 1 commit into from
Oct 7, 2026
Merged

Fix dangling stack references in ParseGuid and subscription parsing #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/Convert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,11 +566,11 @@ bool sttp::IsGuid(const string& value)
Guid sttp::ParseGuid(const uint8_t* data, const bool swapEndianness)
{
Guid id;
uint8_t swappedBytes[16];
uint8_t* encodedBytes;

if (swapEndianness)
{
uint8_t swappedBytes[16];
uint8_t copy[8];

for (uint32_t i = 0; i < 16; i++)
Expand Down
2 changes: 1 addition & 1 deletion src/lib/transport/SubscriberConnection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,7 +1402,7 @@ SignalIndexCachePtr SubscriberConnection::ParseSubscriptionRequest(const string&
for (size_t i = 0; i < rows.size(); i++)
{
const DataRowPtr& row = rows[i];
const Guid& signalID = row->ValueAsGuid(signalIDColumn).GetValueOrDefault();
const Guid signalID = row->ValueAsGuid(signalIDColumn).GetValueOrDefault();
string source;
uint64_t id;

Expand Down
Loading