Repository navigation
fix: default HPA metrics for fixed replica bounds - #854
Closed
labuladong wants to merge 1 commit into
Closed
labuladong wants to merge 1 commit into
labuladong wants to merge 1 commit into
Conversation
Co-authored-by: Codex <codex@openai.com>
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Function with minReplicas=maxReplicas=1 and no explicit autoscaling policy gets an HPA with no metrics. Kubernetes defaults it to 80% CPU utilization, while the operator continues comparing it with an empty desired metrics list. The workload and HPA can be healthy, but the Function remains HPAReady=False with Action=Update.
Use the existing default metrics selection when the replica bounds are equal as well. Replica bounds remain fixed. This one-condition change applies through the shared HPA generator used by Functions, Sources, and Sinks.
Validation:
No controller deployment or shared control-plane change was made. Runtime validation of a rebuilt operator remains pending.