Skip to content

chore: fix lint errors - #16385

Merged
kgryte merged 1 commit into
developfrom
claude/trusting-cannon-chamak
Oct 31, 2026
Merged

kgryte merged 1 commit into
developfrom
claude/trusting-cannon-chamak

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-10-29 13:48 UTC and 2026-10-30 13:48 UTC to sibling packages.
  • propagates 43a6e68 ("chore: fix JavaScript lint errors"). no-buffer-constructor is not enabled in the ESLint config and eslint.mk passes --report-unused-disable-directives, so the remaining // eslint-disable-line no-buffer-constructor directives are reported as errors. Removes them from:
    • buffer/from-array (lib/polyfill.js)
    • buffer/from-buffer (lib/polyfill.js)
  • applies the companion doctest fix from the same commit (Number.POSITIVE_INFINITY → Infinity in constants/float64/pinf) to the example for constants/float64/ninf, which displays Number.NEGATIVE_INFINITY instead of -Infinity.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • assert/is-gzip-buffer
  • constants/float64/pinf

What carried over from the reference(s)?

What differed, or what did you have to work out yourself?

  • None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation: searched all of lib/node_modules/@stdlib for eslint-disable-line no-buffer-constructor in JavaScript files and for // =>/returns annotations displaying Number.(POSITIVE|NEGATIVE)_INFINITY. Two independent reviewers then confirmed each site against eslint.config.js, etc/eslint/rules/*, and the doctest comparison helpers: compareValues( -Infinity, 'Number.NEGATIVE_INFINITY' ) reports the error, and -Infinity passes. Excluded: mentions of no-buffer-constructor in README code blocks, because the Markdown lint config does not report unused directives.

Not addressed here: in the flat config, stdlib/doctest is 'off' (etc/eslint/rules/stdlib.js) and the examples block does not turn it back on. The CI script still passes ESLINT_CONF=.eslintrc.examples.js, but that file no longer exists. As a result, doctest errors in examples/ may no longer be reported. This is worth checking separately.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated fix-propagation routine.


@stdlib-js/reviewers


Generated by Claude Code

Propagates fix from 43a6e68 ("chore: fix JavaScript lint errors") to sibling packages with the same lint errors: removes unused `no-buffer-constructor` disable directives and corrects a doctest annotation displaying `Number.NEGATIVE_INFINITY` instead of `-Infinity`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD77cnhbVqWw5KgWLJdd
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Oct 30, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
buffer/from-array $\\color{green}192/192$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}192/192$
$\\color{green}+100.00\\%$
buffer/from-buffer $\\color{green}202/202$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}202/202$
$\\color{green}+100.00\\%$
constants/float64/ninf $\\color{green}60/60$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}0/0$
$\\color{green}+100.00\\%$
$\\color{green}60/60$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review October 31, 2026 01:49
@kgryte
kgryte requested a review from a team October 31, 2026 01:49
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 31, 2026
@kgryte kgryte changed the title chore: fix lint errors in buffer/* and constants/float64/ninf chore: fix lint errors Oct 31, 2026
@kgryte
kgryte merged commit 4610233 into develop Oct 31, 2026
52 checks passed
@kgryte
kgryte deleted the claude/trusting-cannon-chamak branch October 31, 2026 01:50
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants