Repository navigation
chore: fix lint errors - #16385
Merged
Merged
chore: fix lint errors#16385
Conversation
Propagates fix from 43a6e68 ("chore: fix JavaScript lint errors") to sibling packages with the same lint errors: removes unused `no-buffer-constructor` disable directives and corrects a doctest annotation displaying `Number.NEGATIVE_INFINITY` instead of `-Infinity`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD77cnhbVqWw5KgWLJdd
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Oct 31, 2026
buffer/* and constants/float64/ninf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-10-29 13:48 UTC and 2026-10-30 13:48 UTC to sibling packages.no-buffer-constructoris not enabled in the ESLint config andeslint.mkpasses--report-unused-disable-directives, so the remaining// eslint-disable-line no-buffer-constructordirectives are reported as errors. Removes them from:buffer/from-array(lib/polyfill.js)buffer/from-buffer(lib/polyfill.js)Number.POSITIVE_INFINITY→Infinityinconstants/float64/pinf) to the example forconstants/float64/ninf, which displaysNumber.NEGATIVE_INFINITYinstead of-Infinity.Related Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
assert/is-gzip-bufferconstants/float64/pinfQuestions
No.
Other
Validation: searched all of
lib/node_modules/@stdlibforeslint-disable-line no-buffer-constructorin JavaScript files and for// =>/returnsannotations displayingNumber.(POSITIVE|NEGATIVE)_INFINITY. Two independent reviewers then confirmed each site againsteslint.config.js,etc/eslint/rules/*, and the doctest comparison helpers:compareValues( -Infinity, 'Number.NEGATIVE_INFINITY' )reports the error, and-Infinitypasses. Excluded: mentions ofno-buffer-constructorin README code blocks, because the Markdown lint config does not report unused directives.Not addressed here: in the flat config,
stdlib/doctestis'off'(etc/eslint/rules/stdlib.js) and the examples block does not turn it back on. The CI script still passesESLINT_CONF=.eslintrc.examples.js, but that file no longer exists. As a result, doctest errors inexamples/may no longer be reported. This is worth checking separately.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as part of an automated fix-propagation routine.
@stdlib-js/reviewers
Generated by Claude Code