Skip to content

refactor!: update fft/base/fftpack/float32/sinqi to use integer array view - #16361

Open
gunjjoshi wants to merge 3 commits into
stdlib-js:developfrom
gunjjoshi:float32/sinqi-integer-view
Open

gunjjoshi wants to merge 3 commits into
stdlib-js:developfrom
gunjjoshi:float32/sinqi-integer-view

Conversation

@gunjjoshi

Copy link
Copy Markdown
Member

Resolves a part of stdlib-js/metr-issue-tracker#1321.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding
  • Code review

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Claude code to review code and implement changes in docs and tests.


@stdlib-js/reviewers

…ay view

BREAKING CHANGE: migrate from `Float32Array` to `Uint32Array` for reading radix factorization results

To migrate, users should read the radix factor table section of the
workspace via a `Uint32Array` view over the underlying buffer, rather
than reading directly from the `Float32Array` workspace.

Ref: stdlib-js/metr-issue-tracker#1321
@gunjjoshi gunjjoshi added the METR Pull request associated with the METR project. label Oct 29, 2026
@gunjjoshi
gunjjoshi requested a review from a team October 29, 2026 12:37
@gunjjoshi gunjjoshi added the release: Major Breaking change requiring a new major release. label Oct 29, 2026
@gunjjoshi gunjjoshi mentioned this pull request Oct 29, 2026
4 of 7 tasks
@stdlib-bot

stdlib-bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
fft/base/fftpack/float32/sinqi $\\color{green}226/226$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}226/226$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 29, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

METR Pull request associated with the METR project. release: Major Breaking change requiring a new major release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants