Skip to content

feat: add words and strided method for uint64/base/assert/is-equal - #16318

Open
impawstarlight wants to merge 1 commit into
stdlib-js:developfrom
impawstarlight:feature/uint64-is-equal
Open

impawstarlight wants to merge 1 commit into
stdlib-js:developfrom
impawstarlight:feature/uint64-is-equal

Conversation

@impawstarlight

Copy link
Copy Markdown
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds two methods for comparing two 64-bit unsigned integers using raw words.

Related Issues

Does this pull request have any related issues?

No.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

No.

Questions

Any questions for reviewers of this pull request?

  • Is it okay to delete the branched variant since it always seems to be slightly slower (even on highly predictable inputs) than the branchless variant?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Utilized Antigravity to conduct performance investigation and assembly analysis.


@stdlib-js/reviewers

@impawstarlight
impawstarlight requested a review from a team October 25, 2026 22:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 25, 2026
@impawstarlight impawstarlight added the Enhancement Issue or pull request for enhancing existing functionality. label Oct 25, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
number/uint64/base/assert/is-equal $\\color{green}217/217$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}217/217$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Issue or pull request for enhancing existing functionality. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants