Skip to content

fix: use format for map argument validation errors in array/bool and array/float16 #16243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 2 commits into
base: develop
Choose a base branch
from
+2 −2
Draft

fix: use format for map argument validation errors in array/bool and array/float16 #16243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4d5f1d
fix: use `format` when constructing error message in `array/bool#map`
claude Oct 19, 2026
747b596
fix: use `format` when constructing error message in `array/float16#map`
claude Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/array/bool/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@
if ( !isBooleanArray( this ) ) {
throw new TypeError( 'invalid invocation. `this` is not a boolean array.' );
}
// FIXME: prefer a functional `copyWithin` implementation which addresses lack of universal browser support (e.g., IE11 and Safari) or ensure that typed arrays are polyfilled

Check warning on line 537 in lib/node_modules/@stdlib/array/bool/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'fixme' comment: 'FIXME: prefer a functional `copyWithin`...'
if ( arguments.length === 2 ) {
this._buffer.copyWithin( target, start );
} else {
Expand Down Expand Up @@ -734,7 +734,7 @@
if ( !isBooleanArray( this ) ) {
throw new TypeError( 'invalid invocation. `this` is not a boolean array.' );
}
if ( !isBoolean( value ) ) {

Check warning on line 737 in lib/node_modules/@stdlib/array/bool/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

File has too many lines (1093). Maximum allowed is 300
throw new TypeError( format( 'invalid argument. First argument must be a boolean. Value: `%s`.', value ) );
}
buf = this._buffer;
Expand Down Expand Up @@ -1502,13 +1502,13 @@
throw new TypeError( 'invalid invocation. `this` is not a boolean array.' );
}
if ( !isFunction( fcn ) ) {
throw new TypeError( 'invalid argument. First argument must be a function. Value: `%s`.', fcn );
throw new TypeError( format( 'invalid argument. First argument must be a function. Value: `%s`.', fcn ) );
}
buf = this._buffer;
out = new this.constructor( this._length );
outbuf = out._buffer; // eslint-disable-line no-underscore-dangle
for ( i = 0; i < this._length; i++ ) {
outbuf[ i ] = Boolean( fcn.call( thisArg, Boolean( buf[ i ] ), i, this ) );

Check warning on line 1511 in lib/node_modules/@stdlib/array/bool/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

This line has a length of 83. Maximum allowed is 80
}
return out;
});
Expand Down Expand Up @@ -1769,7 +1769,7 @@
// We need to copy source values...
tmp = new Uint8Array( sbuf.length );
for ( i = 0; i < sbuf.length; i++ ) {
tmp[ i ] = sbuf[ i ]; // TODO: handle accessor arrays

Check warning on line 1772 in lib/node_modules/@stdlib/array/bool/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: handle accessor arrays'
}
sbuf = tmp;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/array/float16/lib/polyfill/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@
if ( !isFloat16Array( this ) ) {
throw new TypeError( 'invalid invocation. `this` is not a floating-point number array.' );
}
// FIXME: prefer a functional `copyWithin` implementation which addresses lack of universal browser support (e.g., IE11 and Safari) or ensure that typed arrays are polyfilled

Check warning on line 577 in lib/node_modules/@stdlib/array/float16/lib/polyfill/index.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'fixme' comment: 'FIXME: prefer a functional `copyWithin`...'
if ( arguments.length === 2 ) {
this._buffer.copyWithin( target, start );
} else {
Expand Down Expand Up @@ -1446,7 +1446,7 @@
throw new TypeError( 'invalid invocation. `this` is not a floating-point number array.' );
}
if ( !isFunction( fcn ) ) {
throw new TypeError( 'invalid argument. First argument must be a function. Value: `%s`.', fcn );
throw new TypeError( format( 'invalid argument. First argument must be a function. Value: `%s`.', fcn ) );
}
buf = this._buffer;
out = new this.constructor( this._length );
Expand Down
Loading