Repository navigation
docs: fix missing examples and fix spacing - #16006
Merged
Merged
Conversation
Added missing `@example` blocks to `lib/native.js`, mirroring `lib/main.js` (present in 375 of 376 native `lib/native.js` files in `math/base/special`; 99.7%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6E4g9jgiqjd2XenrYCtu8
Normalized `( acsc instanceof Error )` parenthesis spacing in `benchmark/benchmark.native.js` (spaced form used in 375 of 376 native benchmarks in `math/base/special`; the unspaced form is the only occurrence in stdlib). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6E4g9jgiqjd2XenrYCtu8
Normalized `resolve( __dirname, ... )` parenthesis spacing in `test/test.native.js` (spaced form used in 375 of 376 native test files in `math/base/special`; the unspaced form is the only occurrence in stdlib). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6E4g9jgiqjd2XenrYCtu8
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
October 11, 2026 12:41
kgryte
approved these changes
Oct 11, 2026
math/base/special/erfinvf native wrapper and fix spacing in acsc and erfcx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
@exampleblocks tomath/base/special/erfinvf/lib/native.jsand normalizes two one-off parenthesis-spacing deviations inmath/base/special/acscandmath/base/special/erfcx, each the sole outlier against a ≥99% namespace convention.Namespace summary
@stdlib/math/base/special. 384 members, 376 with a native addon, none autogenerated. Generatedpolyval_*/rational_*helper files were excluded from extraction.package.jsontop-level/scripts/__stdlib__keys,manifest.jsonkeys, README##/###sections, and, forlib/{main,native,index}.js, the exported signature, JSDoc tags (@param,@returns,@throws,@example,@private), error construction,@modulepath, and thetryRequire/skipboilerplate in native tests and benchmarks.package.jsonkey set,## Usage/## Examples/## C APIsREADME sections, and JSDoc@param/@returns/@exampleonmain.jsandnative.js.__stdlib__inpackage.json(269/384) and## See Also(237/384, generator-owned).math/base/special/erfinvflib/native.jsis the only one of 376 native wrappers in the namespace without@exampleblocks (375/376, 99.7%). The added examples are copied verbatim fromlib/main.js, the same wayerfinv/lib/native.jsrepeats itsmain.jsexamples.src/main.chandles the same special cases as the JS implementation, and the addon is single precision, so the annotated values hold for the native path.math/base/special/acscbenchmark/benchmark.native.jswrites(acsc instanceof Error)with no spaces inside the parentheses. The other 375 native benchmarks use the spaced form, and this is the only unspaced occurrence in stdlib (4887 files use the spaced form). The change is whitespace only.math/base/special/erfcxtest/test.native.jswritesresolve(__dirname, ...)with no space after the opening parenthesis. The other 375 native test files use the spaced form, and this is the only unspaced occurrence in stdlib (6004 files use the spaced form). The change is whitespace only.Related Issues
No.
Questions
No.
Other
Validation
lib/{main,native,index}.jsfor all members. A per-package agent pass over 384 packages would have been rate-limit bound.confirmed-driftfor each correction. One of them confirmed that thejsdoc-doctestlint rule skipsnative.jswhen the addon is unbuilt, and that the annotated values matcherfinvf/src/main.c.Deliberately excluded
gammaincinv/lib/main.jsmissing@example: open PR docs: add JSDoc examples tomath/base/special/gammaincinv#15948 already covers it.maxn,minn,maxabsn,minabsn,minmaxn,minmaxabsn,siciand thefastparent: these are pure JS by design. The first six are variadic,sicireturns an array, andfastis a namespace package.benchmark/c/native/incfloor,hyp2f1,sqrtpif: adding it means writing package-specific C, which is not a mechanical fix.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code on behalf of @Planeshifter as an automated cross-package drift audit of
@stdlib/math/base/special. Agents validated the findings, and a maintainer will review them before the PR leaves draft.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01E6E4g9jgiqjd2XenrYCtu8
Generated by Claude Code