Repository navigation
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
stdlib-bot
added
Needs Review
Contributor
|
@CoDe-ReDz change pr title to |
CoDe-ReDz
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15995.
Description
This pull request:
stdlib/require-last-path-relativelint error reported in Fix JavaScript lint errors #15995 for@stdlib/math/base/tools/evalrational-compile/examples/index.jsby adding aneslint-disable-linefor that rule on the@stdlib/utils/try-requireimport, following the convention used by other examples (e.g.,@stdlib/strided/common/examples/addon-napi-polymorphic/index.js). The example intentionally loads the package viatryRequire( resolve( __dirname, '..', 'lib' ) )to guard against unsupported environments, so the rule, which only inspectsrequire( '<literal>' )calls, seestry-requireas the lastrequire.Related Issues
This pull request has the following related issues:
Questions
@stdlib/math/base/tools/evalpoly-compilehas the same example structure and fails the same lint rule (I confirmed this locally).evalpoly-compile-candevalrational-compile-cuse the sametryRequire( resolve( __dirname, ... ) )pattern. Would you like those fixed in this PR as well, or would you prefer a different approach (e.g., having the rule recognizetryRequire( resolve( ... ) ))?Other
Verified locally with
make lint-javascript-files FILES="lib/node_modules/@stdlib/math/base/tools/evalrational-compile/examples/index.js" ESLINT_CONF=etc/eslint/.eslintrc.examples.js(no errors) and by running the example with Node. The error only reproduces with the examples ESLint configuration, which is the one that enables this rule.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used Claude (an AI assistant) to help me understand the repository's lint setup, the
stdlib/require-last-path-relativerule, and the contribution workflow. I applied it myself and verified it by running ESLint with the examples configuration and by running the example with Node.@stdlib-js/reviewers