Repository navigation
docs: update JSDoc comments - #15997
Merged
Merged
Conversation
… example Use `benchmark-lang` as the command key in the JSDoc example, matching the plugin's registration in `etc/.makie.js` (example command key equals registered command name in 22/23 siblings, 96%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCsdkkh843smiUCvB2GZqx
…s` example Removed the blank line between the `require()` statements and the options object in the JSDoc example (absent in 22/23 siblings, 96%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCsdkkh843smiUCvB2GZqx
…akie-markdown-asset-link`
Removed `@returns {void}` from the private `onError` callback, which has
no return statement (tag absent in 21/22 siblings defining `onError`, 95%).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LCsdkkh843smiUCvB2GZqx
kgryte
marked this pull request as ready for review
October 11, 2026 12:48
…e-list-pkgs/lib/index.js
kgryte
approved these changes
Oct 11, 2026
_tools/makie/plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
_tools/makie/pluginspackages that differed from the convention shared by nearly all of their siblings. Two of the three are documentation errors.Namespace summary. 23 members, none autogenerated. Checked: file tree,
package.jsonkey sets,scripts/stdlibkey sets, README/manifest presence, test/benchmark/example files, public signature, return kind, validation prologue, error construction, JSDoc shape and dependencies. All structural features are 100% uniform: every package contains onlylib/index.js,lib/main.jsandpackage.json. Semantic features with a clear majority (≥75%): JSDoc example shape, private-callback JSDoc tags, and the description matching betweenindex.jsandmain.js. Signature and validation features have no clear majority because some plugins take nosubpathorcwd. They were excluded.makie-benchmark-langThe
@exampleinlib/index.jsregistered the plugin underbenchmarkand invokedbenchmark, a leftover frommakie-benchmark.etc/.makie.jsregisters it asbenchmark-lang, and the example now uses that name. In 22/23 siblings (96%) the example key equals the registered command name.makie-markdown-asset-linkRemoves
@returns {void}from the privateonErrorcallback, which has noreturnstatement. The tag is absent in 21/22 siblings that defineonError(95%).makie-list-pkgsRemoves a stray blank line between the
require()statements and the options object in the@example. It is absent in 22/23 siblings (96%).Related Issues
No.
Questions
makie-markdown-examples-javascripthas a description inlib/main.js("...in README.md files") that differs fromlib/index.jsandpackage.json("...in Markdown files"). The underlying make rule filters onREADME.md, somain.jsis arguably the accurate one. This PR leaves it unchanged. Which wording should be canonical?Other
Validation. Structural features were extracted directly from the filesystem. Semantic features came from source diffs of every
lib/main.jsandlib/index.jsagainst a reference sibling. Two independent review passes then checked each candidate: one for intentional versus unintentional deviation, and one for repo-wide reliance on the current text. Deliberately excluded:makie-install-node-addonslocalchildvariable. The majority'svar procshadows the module-levelproc, so the outlier is the better pattern.makie-markdown-examples-javascriptdescription, which needs a human decision (see Questions).makie-repl,makie-list-pkgs-names,makie-view-covandmakie-view-complexity, which are intentional.All changes are JSDoc only, with no behavior change.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, as part of an automated cross-package API drift detection run.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01LCsdkkh843smiUCvB2GZqx
Generated by Claude Code