Repository navigation
test: migrate stats/base/dists/exponential/skewness to ULP-based assertions - #15991
Merged
kgryte merged 1 commit intoOct 11, 2026
Merged
Conversation
…sertions Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GdLaCkawSrFRx68zu3m1pM
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/exponential/skewnessfrom EPS-based tolerance assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value.test/test.native.jsonly (test/test.jsalready uses exact comparison, as the skewness is the constant2). Removes the now-unusedabsandEPSimports and thedelta/tolvariables.0. Measured minimum over the full fixture set (native addon built and run, not skipped):0ULP; the suite was run twice with identical results (55/55 passing).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The literal ULP argument follows the convention used in sibling conversions (e.g.,
exponential/variance). The commit was created with--no-verifybecause the pre-commit editorconfig hook could not download its binary in the sandbox;eslintpasses on the changed file.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as a scheduled routine.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01GdLaCkawSrFRx68zu3m1pM
Generated by Claude Code