Conversation
Replaces the computed relative tolerance assertions in the fixture loops with `isAlmostSameValue` ULP comparisons. The ULP bound was tightened to the measured minimum of 1 ULP over the full Julia fixture set. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013v2kAY2MhA6iFWBEBPWRUk --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/gumbel/entropyfrom relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomputation andt.ok( delta <= tol, ... )assertion in the Julia fixture loops oftest/test.jsandtest/test.native.jswitht.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' );.@stdlib/assert/is-almost-same-valuerequire and drops the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.Final ULP constant:
1(used in bothtest/test.jsandtest/test.native.js).This is the measured minimum. Over the full 100-element Julia fixture set, the largest observed ULP difference between the returned and expected values is exactly 1; at
0ULP, 16 of the 110 assertions fail. The suite was run twice at the final value with identical results (110/110 passing, no FMA/arch variation). Consistent with the convention in already-migrated sibling packages (e.g.lognormal/entropy,normal/entropy), the same bound is used in the native test file.Only the two test files are changed.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
make test TESTS_FILTER=".*/stats/base/dists/gumbel/entropy/.*"could not be used in this environment:make install-node-modulesfails becausees-object-atoms@^1.1.2is not published (the registry has at most1.1.1). This is a pre-existing dependency-resolution failure unrelated to this change. The package's test files were instead executed directly against the repository'slib/node_modulestree, giving 110/110 passing fortest/test.js;test/test.native.jsskips, as the native add-on is not built.etc/eslint/.eslintrc.tests.js) over both changed files and is clean. Theeditorconfig-checkerstep could not execute because its binary is downloaded from GitHub releases, which is unavailable here; both files were verified manually against.editorconfig(LF line endings, UTF-8, tab indentation, no trailing whitespace, final newline).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, running as an unattended scheduled task. Claude studied #11352 and the already-migrated sibling packages to mirror the established idiom, applied the migration, and determined the ULP bound empirically by measuring the per-fixture ULP difference and confirming the suite fails at
0and passes deterministically at1.@stdlib-js/reviewers
Generated by Claude Code