Skip to content

chore: clean-up - #13584

Merged
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-07-20
Jul 20, 2026
Merged

kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-07-20

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Jul 20, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-07-19T13:04:31-07:00 (2b91bfe) and 2026-07-20T00:58:01-07:00 (2f69188).

This pull request:

  • blas/ext/base/ndarray/gxdy: the README examples (blas/ext/base/ndarray/gxdy/README.md, introduced in 64d2677) generate y via discreteUniform( [ 10 ], -100, 100, opts ), allowing zero divisors; changed the bounds to 1, 100 to match examples/index.js and the dxdy/sxdy siblings.
  • blas/ext/base/dfirst-index-less-than: removed the stray, unused @stdlib/types triple-slash reference directive from blas/ext/base/dfirst-index-less-than/docs/types/index.d.ts (introduced in bd18166); the file only touches Float64Array/number, and neither sfirst-index-less-than nor dfirst-index-equal carry it.
  • blas/ext/base/dfirst-index-less-than: removed the dead y declaration in the "fourth argument" test block of dfirst-index-less-than/docs/types/test.ts, left over from bd18166 where y was never referenced once the fourth argument was swapped for invalid values — matches sfirst-index-less-than and dfirst-index-equal, which never declared it.
  • blas/ext/base/dfirst-index-less-than: fixed the repl.txt signature heading in dfirst-index-less-than/docs/repl.txt to include the .ndarray suffix, matching the examples below it and sfirst-index-less-than/dfirst-index-equal; missed in bd18166.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 24 commits merged to develop in the 24-hour window were reviewed for (1) stdlib style-guide compliance (docs/style-guides), audited by comparison against established sibling/reference packages (dfirst-index-equal, sfirst-index-less-than, dxdy, sxdy), and (2) bugs in the introduced code (logic, dtype consistency across d/s/g variants, stride/offset handling, C sources, ULP test migrations). Only objective, independently re-verified issues were retained; subjective concerns, style preferences not required by the style guides, test-coverage gaps, and anything requiring changes outside the reviewed diff were deliberately excluded. Bot-generated churn (equation SVG CDN-hash bumps, regenerated TypeScript declarations, REPL data) was inspected and left untouched.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was produced by an automated commit-review routine run with Claude Code: AI agents reviewed the last 24 hours of commits merged to develop, and the retained fixes were applied and committed by Claude Code. All findings were independently re-verified against the repository before inclusion.


@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 20, 2026
@stdlib-bot

stdlib-bot commented Jul 20, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dfirst-index-less-than $\\color{green}372/372$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}372/372$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/gxdy $\\color{green}111/111$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}111/111$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review July 20, 2026 16:57
@Planeshifter
Planeshifter requested review from a team and kgryte July 20, 2026 16:57
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. labels Jul 20, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 20, 2026
@kgryte kgryte changed the title fix: follow-up fixes for recent commits merged to develop (2026-07-20 review) chore: clean-up Jul 20, 2026
@kgryte
kgryte merged commit b772009 into develop Jul 20, 2026
59 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-07-20 branch July 20, 2026 20:08
@Planeshifter Planeshifter mentioned this pull request Jul 21, 2026
4 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants