Repository navigation
chore: clean-up - #13584
Merged
Merged
chore: clean-up#13584
Conversation
…rst-index-less-than`
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-07-19T13:04:31-07:00 (2b91bfe) and 2026-07-20T00:58:01-07:00 (2f69188).This pull request:
blas/ext/base/ndarray/gxdy: the README examples (blas/ext/base/ndarray/gxdy/README.md, introduced in 64d2677) generateyviadiscreteUniform( [ 10 ], -100, 100, opts ), allowing zero divisors; changed the bounds to1, 100to matchexamples/index.jsand thedxdy/sxdysiblings.blas/ext/base/dfirst-index-less-than: removed the stray, unused@stdlib/typestriple-slash reference directive fromblas/ext/base/dfirst-index-less-than/docs/types/index.d.ts(introduced in bd18166); the file only touchesFloat64Array/number, and neithersfirst-index-less-thannordfirst-index-equalcarry it.blas/ext/base/dfirst-index-less-than: removed the deadydeclaration in the "fourth argument" test block ofdfirst-index-less-than/docs/types/test.ts, left over from bd18166 whereywas never referenced once the fourth argument was swapped for invalid values — matchessfirst-index-less-thananddfirst-index-equal, which never declared it.blas/ext/base/dfirst-index-less-than: fixed the repl.txt signature heading indfirst-index-less-than/docs/repl.txtto include the.ndarraysuffix, matching the examples below it andsfirst-index-less-than/dfirst-index-equal; missed in bd18166.Related Issues
No.
Questions
No.
Other
Validation. All 24 commits merged to
developin the 24-hour window were reviewed for (1) stdlib style-guide compliance (docs/style-guides), audited by comparison against established sibling/reference packages (dfirst-index-equal,sfirst-index-less-than,dxdy,sxdy), and (2) bugs in the introduced code (logic, dtype consistency acrossd/s/gvariants, stride/offset handling, C sources, ULP test migrations). Only objective, independently re-verified issues were retained; subjective concerns, style preferences not required by the style guides, test-coverage gaps, and anything requiring changes outside the reviewed diff were deliberately excluded. Bot-generated churn (equation SVG CDN-hash bumps, regenerated TypeScript declarations, REPL data) was inspected and left untouched.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by an automated commit-review routine run with Claude Code: AI agents reviewed the last 24 hours of commits merged to
develop, and the retained fixes were applied and committed by Claude Code. All findings were independently re-verified against the repository before inclusion.