Skip to content

Migrate to ESLint 10 and ESLint React #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danbarr merged 3 commits into from
Oct 16, 2026
Merged

Migrate to ESLint 10 and ESLint React #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f58e22e
Migrate to ESLint 10 and ESLint React
danbarr Oct 14, 2026
63c8320
Fix warnings from React lint migration
danbarr Oct 14, 2026
6657892
Preserve undefined component checks in partials
danbarr Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/_static-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
- name: Run ESLint
run: npm run eslint

- name: Run TypeScript type checking
run: npm run typecheck

- name: Run Prettier
run: npm run prettier

Expand Down
34 changes: 21 additions & 13 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { fileURLToPath } from 'node:url';
import globals from 'globals';
import pluginJs from '@eslint/js';
import tseslint from 'typescript-eslint';
import pluginReact from 'eslint-plugin-react';
import eslintReact from '@eslint-react/eslint-plugin';
import eslintConfigPrettier from 'eslint-config-prettier';
import * as mdx from 'eslint-plugin-mdx';

Expand All @@ -19,7 +19,19 @@ export default [

pluginJs.configs.recommended,
...tseslint.configs.recommended,
pluginReact.configs.flat.recommended,
{
...eslintReact.configs['recommended-typescript'],
rules: {
...eslintReact.configs['recommended-typescript'].rules,
// Preserve checks from eslint-plugin-react's recommended preset.
'@eslint-react/no-missing-component-display-name': 'error',
'@eslint-react/no-missing-context-display-name': 'error',
'@eslint-react/jsx-no-children-prop': 'error',
'@eslint-react/jsx-no-comment-textnodes': 'error',
'@eslint-react/dom-no-unknown-property': 'error',
'@eslint-react/dom-no-unsafe-target-blank': 'error',
},
},
eslintConfigPrettier,

// Configs for .mdx files
Expand All @@ -31,8 +43,10 @@ export default [
}),
rules: {
...mdx.flat.rules,
'react/no-unescaped-entities': 'off',
'react/jsx-no-undef': ['error', { allowGlobals: true }],
// ESLint 10 tracks JSX component references, including MDX globals.
'no-undef': 'error',
Comment thread
danbarr marked this conversation as resolved.
// MDX JSX expressions compile into the page component's render body.
'@eslint-react/rules-of-hooks': 'off',
'mdx/remark': 'off', // remark-lint's auto-fix clobbers MDX formatting
},
languageOptions: {
Expand All @@ -56,18 +70,12 @@ export default [
// Config for _partials with JSX props
{
files: ['docs/**/_partials/*.mdx'],
languageOptions: {
globals: { props: 'readonly' },
},
rules: {
'no-unused-expressions': 'off',
'@typescript-eslint/no-unused-expressions': 'off',
'no-undef': 'off',
},
},

{
settings: {
react: {
version: 'detect',
},
},
},
];
Loading
Loading