Skip to content

fix(configurator): retain runner observation freshness #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lweberru merged 1 commit into from
Oct 24, 2026
Merged

fix(configurator): retain runner observation freshness #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion landing-zone-configurator/app/apps/api/src/applications/interrupted-plan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ export async function completeInterruptedPlan(
// Recheck after State observation; neither a stale CF read nor an expired
// historical proof can authorize this terminal transition.
await verifyStopped();
const observedAt = new Date().toISOString();
try {
const last = await read(backend, backend.descriptor.key);
if (
Expand All @@ -166,7 +167,7 @@ export async function completeInterruptedPlan(
if (error instanceof RecoveryReplanError) throw error;
fail("state_unavailable");
}
const observedAt = new Date().toISOString();
if (Date.now() - Date.parse(observedAt) > 30_000) fail("changed");
return work(async (client) => {
const latest = await context(client);
const { existingReceipt: _before, ...before } = c;
Expand Down
28 changes: 28 additions & 0 deletions landing-zone-configurator/app/tests/application-interrupted-plan.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,3 +319,31 @@ it("revalidates bindings in a new transaction after external observations", asyn
});
expect(f.recorded()).toBe(false);
});
it.each([29_000, 31_000])(
"retains the actual Runner observation time across a %sms final State read",
async (delay) => {
vi.useFakeTimers({ toFake: ["Date"] });
const observed = new Date("2026-01-01T00:00:00.000Z");
vi.setSystemTime(observed);
try {
const f = fixture();
let reads = 0;
f.read.mockImplementation(async (_backend, key) => {
if (!key.endsWith(".tflock") && ++reads === 3)
vi.setSystemTime(observed.getTime() + delay);
return null;
});
if (delay > 30_000) {
await expect(f.run()).rejects.toMatchObject({
code: "application_plan_recovery_changed",
});
expect(f.recorded()).toBe(false);
} else {
await expect(f.run()).resolves.toMatchObject({ status: "failed" });
expect(f.query.mock.calls.at(-1)?.[1][4]).toBe(observed.toISOString());
}
} finally {
vi.useRealTimers();
}
},
);
Loading