Repository navigation
fix(assistant): ground DNS completion in saved metadata context - #142
Merged
Merged
Conversation
lweberru
requested review from
Breeless,
JoshSTACKIT,
LembDo and
dweezl
as code owners
October 23, 2026 09:08
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
The qualified Dev release for #135 stopped before build/deployment: both
dns-ownerrepetitions asked for known DNS metadata/contact decisions instead of preparing the explicitly requested reviewable completion (122/124 cases passed; continuous journey passed). Those failures remain recorded in release 39925017270.Supply DNS intent classification with stable zone keys, validated field-presence flags and confirmed contact-source availability. Actual domain/contact values and unknown fields are excluded from this additional context. Require an explicit DNS-task decision in the serving schema while retaining legacy parser compatibility. Keep a semantic remaining-settings decision coherent with draft mode and distinguish metadata completion from source-evidenced add/replace operations. Existing field/contact/preservation/evidence/acceptance guards and all factual oracles remain unchanged; nothing is persisted or executed by classification.
Regenerate source-bound knowledge/catalogue metadata and update EN/DE contributor guidance. Add regression coverage for contradictory advice mode, actual classifier context, required task selection and downstream rejection of missing/invented/overbroad proposals. Informational requests retain advice behavior.
Validation and limits
Final lint/build/type checks passed locally; full unit suite: 1052 passed, 71 environment-gated skipped. All eight DNS cases passed twice against the configured real model (16/16) on this final source, including both owner-contact completion repetitions. The earlier restricted-loopback test run is not counted as a functional pass; the complete suite passed with the required local test permissions. Intermediate experiments are not qualification: one earlier version failed collection-evidence checks, another had a truncated model response. No failed repetition is relabelled as success. A fresh full qualified release remains mandatory before Dev promotion.
No migrations, IAM grants, customer Plan/Apply, State changes or production operations. Related #95 and #93; no acceptance criterion is weakened.