Skip to content

fix(configurator): clean up immutable staging directories safely - #125

Merged
lweberru merged 2 commits into
mainfrom
fix/configurator-staging-cleanup
Oct 21, 2026
Merged

lweberru merged 2 commits into
mainfrom
fix/configurator-staging-cleanup

Conversation

@lweberru

@lweberru lweberru commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Dev release 39556768148 passed application, database, browser, native OpenTofu and real image-backed Runner checks. Both thin archives restored the exact qualified package identity. The build then failed in the staging verifier's finally cleanup: its extracted provider directories are deliberately read-only, so recursive removal raised EACCES under the non-root GitHub runner. No artifact was published and no deployment occurred.

After qualification, make only directories inside the verifier's temporary staging tree writable before removing it. Use lstat and avoid traversing symlinks, preserving the original Runner/provider mirror, file permissions and package bytes. Keep all qualification assertions and deployment gates unchanged. Include the staging regressions in the ordinary PR operator checks so this permission failure is caught before a release. Update the English/German image-staging runbook.

Validation:

  • New non-root regression reproduces EACCES with an immutable provider tree, then verifies cleanup succeeds while a symlink target's directory mode, provider inode, file mode and bytes remain unchanged.
  • Release/artifact/buildpack/image-staging guards: 34 passed under dev-skip-assistant-qualification.
  • Pinned npm run check: 977 passed, 69 existing default-gated skips; script lint and git diff --check pass.

After merge, start a fresh Dev release with release_mode=dev-skip-assistant-qualification, runner_pool_size=1, build_only=false and empty release_run_id. The failed run remains evidence; no re-run or gate bypass. Hosted warm-pool handoff and replacement verification remains required. No production or customer infrastructure Apply.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lweberru
lweberru merged commit 9eb15df into main Oct 21, 2026
13 checks passed
@lweberru
lweberru deleted the fix/configurator-staging-cleanup branch October 21, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant