Repository navigation
Upgrade NullAway to 0.13.8 - #698
Merged
Merged
Conversation
Error Prone 2.50.0 (#693) no longer contains com.google.errorprone.predicates.type.DescendantOf, which NullAway 0.12.15 references directly. Compiling with NullAway enabled fails with: Failed to initialize com.uber.nullaway.NullAway Caused by: NoClassDefFoundError: com/google/errorprone/predicates/type/DescendantOf NullAway 0.13.2 and later use TypePredicates.isDescendantOf instead, and 0.13.8 is built and tested against Error Prone 2.50.0. Signed-off-by: Ryan Baxter <ryan.baxter@broadcom.com>
ryanjbaxter
force-pushed
the
upgrade-nullaway-0.13.8
branch
from
October 1, 2026 20:30
e41d470 to
55c2738
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error Prone 2.50.0 (#693) removed
com.google.errorprone.predicates.type.DescendantOf, which NullAway 0.12.15 references directly. Any build using the NullAway Error Prone plugin now fails at compile time:This broke spring-cloud-commons main: https://github.com/spring-cloud/spring-cloud-commons/actions/runs/36911651121/job/110538092973
NullAway 0.13.2 and later use
TypePredicates.isDescendantOfinstead, and 0.13.8 is built and tested against Error Prone 2.50.0. This bumpsnullaway.versionfrom 0.12.15 to 0.13.8.Verified locally against spring-cloud-build
5.1.0-20261001.195324-55(Error Prone 2.50.0):-Dnullaway.version=0.13.8:clean test-compilesucceeds for all modulesTests were not run, since the failure is a compile-time plugin crash.