Skip to content

Upgrade NullAway to 0.13.8 - #698

Merged
ryanjbaxter merged 1 commit into
mainfrom
upgrade-nullaway-0.13.8
Oct 1, 2026
Merged

ryanjbaxter merged 1 commit into
mainfrom
upgrade-nullaway-0.13.8

Conversation

@ryanjbaxter

@ryanjbaxter ryanjbaxter commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Error Prone 2.50.0 (#693) removed com.google.errorprone.predicates.type.DescendantOf, which NullAway 0.12.15 references directly. Any build using the NullAway Error Prone plugin now fails at compile time:

Failed to initialize com.uber.nullaway.NullAway
Caused by: NoClassDefFoundError: com/google/errorprone/predicates/type/DescendantOf
  at com.uber.nullaway.handlers.StreamNullabilityPropagatorFactory.getRxStreamNullabilityPropagator

This broke spring-cloud-commons main: https://github.com/spring-cloud/spring-cloud-commons/actions/runs/36911651121/job/110538092973

NullAway 0.13.2 and later use TypePredicates.isDescendantOf instead, and 0.13.8 is built and tested against Error Prone 2.50.0. This bumps nullaway.version from 0.12.15 to 0.13.8.

Verified locally against spring-cloud-build 5.1.0-20261001.195324-55 (Error Prone 2.50.0):

  • spring-cloud-commons with NullAway 0.12.15: fails with the error above
  • spring-cloud-commons with -Dnullaway.version=0.13.8: clean test-compile succeeds for all modules

Tests were not run, since the failure is a compile-time plugin crash.

Error Prone 2.50.0 (#693) no longer contains
com.google.errorprone.predicates.type.DescendantOf, which NullAway
0.12.15 references directly. Compiling with NullAway enabled fails with:

  Failed to initialize com.uber.nullaway.NullAway
  Caused by: NoClassDefFoundError: com/google/errorprone/predicates/type/DescendantOf

NullAway 0.13.2 and later use TypePredicates.isDescendantOf instead, and
0.13.8 is built and tested against Error Prone 2.50.0.

Signed-off-by: Ryan Baxter <ryan.baxter@broadcom.com>
@ryanjbaxter
ryanjbaxter force-pushed the upgrade-nullaway-0.13.8 branch from e41d470 to 55c2738 Compare October 1, 2026 20:30
@ryanjbaxter ryanjbaxter added dependencies Pull requests that update a dependency file and removed waiting-for-triage labels Oct 1, 2026
@ryanjbaxter ryanjbaxter added this to the 5.1.0-RC1 milestone Oct 1, 2026
@ryanjbaxter
ryanjbaxter merged commit 79fcfdf into main Oct 1, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in 2026.0.0-RC1 Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants